[Metricbeat] Google Cloud: Do not try to setup region filter on Cloudfunctions metrics #24218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o in PubSub and LoadBalancing
sayden
added
bug
Metricbeat
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
kaiyan-sheng
approved these changes
Feb 24, 2021
|
/test |
5 tasks
sayden
added a commit
to sayden/beats
that referenced
this pull request
Feb 25, 2021
…functions metrics (elastic#24218) (cherry picked from commit a6a3d6d)
sayden
deleted the
bugfix/xp/mb/googlecloud/do_not_modify_cloud_functions_filters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR solves a bug that appears when setting a
regionparameter ingcp.ymlonly when using CloudFunctions.Some Google Cloud services fail when you request metrics filtering by
region. Beats has faced the same situation when requesting PubSub or LoadBalancing metrics from Stackdriver (Stackdriver is the service requested inmetricsmetricset).Requests to those services must be done explicitly without filtering by region. Unfortunately, this isn't very well documented in GCP docs (or it's well hidden 😄 )
Checklist
[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.